fix some pretty small problem #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
reviewed
Apr 13, 2020
Comment on lines
+435
to
+436
| # 'That,' she said, 'is still pointless.' | ||
| str = ''''That,' she said, 'is still pointless.'''' |
There was a problem hiding this comment.
Oh, yes, it's 725, 727 is this PR...
There was a problem hiding this comment.
I have updated the hash number in PR explain. (Translating 1.0.0 and updating my parser has worn me out and I'm a bit dazed now... But still so excited to see 1.0.0 come)
|
I cannot really see what's that whitespace change in L794, but looks okay in general. |
Thanks for review! A quick way to comapre is to copy the space and compare that with |
pradyunsg
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from #723
I found these when I was translating docs word by word. Since it's rc version now, fixing them do more good than harm.
for #725
Make it clear in example, that multiline literal string can also end with (single) quote less than three, like multiline basic string do now.
#722