Clarify example showing how to add new keys #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 14, 2020
ChristianSi
reviewed
Feb 15, 2020
|
Would it make sense to instead show the JSON-equivalent here? |
|
@pradyunsg I don't think so. |
|
@pradyunsg I'm a little confused. How would the JSON equivalent be useful here? |
pradyunsg
approved these changes
Feb 20, 2020
|
@eksortso I Sorry for the confusion, I might've been a little too tired that day. :) |
|
And right now, as well, apparently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per a conversation regarding point 9 of #701, this PR annotates two examples with comments to show how you can write to unused names, and to show why reusing a name as a table when it originally wasn't is invalid.