Skip to content

build: upgrade windows-sys 0.52 → 0.59 #7117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2025
Merged

build: upgrade windows-sys 0.52 → 0.59 #7117

merged 2 commits into from
Jul 7, 2025

Conversation

ErichDonGubler
Copy link
Contributor

@ErichDonGubler ErichDonGubler commented Jan 22, 2025 •
edited
Loading

Motivation

We at Mozilla would like to upgrade WGPU and crates we otherwise use in mozilla-central to windows 0.59. 😀 This will let us handle breaking changes, and stay in sync. with the current ecosystem for Windows targets.

Solution

Migrate tokio to windows 0.59.

Remaining work

@ErichDonGubler ErichDonGubler mentioned this pull request Jan 22, 2025
Draft
8 tasks
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-net Module: tokio/net labels Jan 22, 2025
@Darksonn
Copy link
Contributor

Thanks for the PR! Happy to merge this once the dependencies are fixed as well.

@elsnerpaul
Copy link

Hi, any update on this? Would love to see this :)

@Darksonn
Copy link
Contributor

This is still waiting for dependencies.

@ErichDonGubler ErichDonGubler force-pushed the windows-sys-0.59 branch 2 times, most recently from 923baab to 6fdab08 Compare June 6, 2025 07:56
@ErichDonGubler
Copy link
Contributor Author

Update on dependencies: mio is now ready to go, just waiting on socket2 now. 😤

@atouchet
Copy link

atouchet commented Jul 5, 2025

socket2 0.6 is finally out.

Tokio update PR: #7443

@Darksonn
Copy link
Contributor

Darksonn commented Jul 7, 2025

Okay socket2 has landed. We can merge this now if it's updated.

@ErichDonGubler ErichDonGubler marked this pull request as ready for review July 7, 2025 17:25
@ErichDonGubler
Copy link
Contributor Author

Removed the patch entry from Cargo.toml. LFG! 😀

Darksonn
Darksonn reviewed Jul 7, 2025
View reviewed changes
Darksonn
Darksonn approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Darksonn Darksonn enabled auto-merge (squash) July 7, 2025 17:32
@Darksonn Darksonn merged commit aff24df into tokio-rs:master Jul 7, 2025
88 checks passed
@ErichDonGubler ErichDonGubler deleted the windows-sys-0.59 branch July 12, 2025 18:30
@hanna-kruppe hanna-kruppe mentioned this pull request Jul 24, 2025
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-net Module: tokio/net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ErichDonGubler @Darksonn @elsnerpaul @atouchet