Bump MSRV to v1.46 #150
Merged
Bump MSRV to v1.46 #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
requested changes
Apr 26, 2025
taiki-e
reviewed
Apr 26, 2025
168d534 to
66e0bf4
Compare
taiki-e
approved these changes
Apr 26, 2025
taiki-e
requested changes
Apr 26, 2025
66e0bf4 to
559da68
Compare
taiki-e
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at crates that made use of build scripts, I've realized that this crate uses a build script to support Rust versions older than 1.46. Given that 1.46 came out 4 years and 8 months ago, I don't think it makes sense anymore to support a version even older than that. Even Debian 11 ships a newer version of Rust.
This bumps the MSRV to v1.46 and removes the build script.
Here's the status on the top 10 reverse dependencies:
futures-utiltokio-utilh2reqwestsharded-slabtowerasync-ioasync-executorfragilequinn-proto