Fix Bytes when Vec pointer's LSB is set #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
reviewed
Dec 14, 2019
| @@ -731,20 +731,23 @@ impl From<Vec<u8>> for Bytes { | |||
| let slice = vec.into_boxed_slice(); | |||
There was a problem hiding this comment.
The is_empty special case above can be removed now that the low bit is being tracked properly.
sfackler
reviewed
Dec 14, 2019
sfackler
approved these changes
Dec 14, 2019
0db53a6 to
30504fd
Compare
This separates the `SharedVtable` into 3: - `PromotableEvenVtable`: The original `SharedVtable`, which will promote the `Vec` to `Shared` on the first clone, and is selected when the `Vec`'s pointer has the LSB unset. - `PromotableOddVtable`: Similar to the `PromotableEvenVtable`, but selected when the `Vec`'s pointer has the LSB set. This vtable differs in the masking used when reconstructing the `Vec`. - `SharedVtable`: This no longer checks if its current kind is `VEC` or `ARC`, and is only created by the "promotable" vtables. This also adds a test using an "odd" global allocator that purposefully bumps all pointers with alignment of 1. Closes #343
30504fd to
6501193
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the
SharedVtableinto 3:PromotableEvenVtable: The originalSharedVtable, which willpromote the
VectoSharedon the first clone, and is selected whenthe
Vec's pointer has the LSB unset.PromotableOddVtable: Similar to thePromotableEvenVtable, butselected when the
Vec's pointer has the LSB set. This vtable differsin the masking used when reconstructing the
Vec.SharedVtable: This no longer checks if its current kind isVECorARC, and is only created by the "promotable" vtables.This also adds a test using an "odd" global allocator that purposefully
bumps all pointers with alignment of 1.
Closes #343