Add macro to compile time check if a path is valid #3288
Conversation
6f912ed to
80505f1
Compare
f8863e2 to
76485a4
Compare
|
aparently the trick I used is only valid on rust 1.80> so I blocked that via a rustversion call. |
|
@SabrinaJewson I have fixed all your concerns. can you re-review? |
fe1953f to
9bec4ab
Compare
|
This seems like a decent fit for |
no worries at all on my side. I'll move it to axum extras as soon as I'm back home. |
9bec4ab to
2182e56
Compare
It's my first time contributing to a rust project, and my first time contributing to axum. so, no, it's not annoying, it's the only way that I can learn. (i'm mostly a c++ dev trying to get away from it).
Yes, I'll do that. |
|
@jplatte did what you asked. but there's a lot of commits that could just be squashed to one. toughts? |
I'm new to rust, so please be kind. :)
For routes created with axum::Router - without the axum_extras TypedRoute, I missed the possibility of a compile time check if the route is valid. I really do prefer the
axum::Router::new().route().route()...to_owned()approach since it's easy to seeallof my routes in one single place.the change seemed simple but it took a few days of effort untill I discovered I could open a
const {}context and work with it.I do not know how to test this, since the test is
compilation failureon the wrong case.previous api:
my proposal:
first I tried my best to
notuse a macro since they can't be called likeimpl functionsbut we work with what we have.on my (400-ish) route project this saved me a bit of time already.