Simplify Handler async blocks #3285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e28d4da to
8c0177e
Compare
8c0177e to
92394fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our internal codebase, this significantly decreases the amount of LLVM IR generated for these (as measured by https://github.com/dtolnay/cargo-llvm-lines):
<F as axum::handler::Handler<(M,T1,T2,T3),S>>::call::{{closure}}from 29046 to 22078 lines across 52 instantiations
<F as axum::handler::Handler<(M,T1,T2,T3,T4),S>>::call::{{closure}}from 30383 to 23077 lines across 46 instantiations
<F as axum::handler::Handler<(M,T1,T2,T3,T4,T5),S>>::call::{{closure}}from 29754 to 22586 lines across 39 instantiations