Skip to content

Require Sync for services #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 28, 2024
Merged

Require Sync for services #2473

merged 4 commits into from
Sep 28, 2024
+137 −47

Conversation

davidpdrsn
Copy link
Member

@davidpdrsn davidpdrsn commented Dec 30, 2023 •
edited by jplatte
Loading

Fixes #1950

This will allow us to use Arc inside Router to make it cheaper to clone.

TODO

  • changelog

@davidpdrsn davidpdrsn added this to the 0.8 milestone Dec 30, 2023
davidpdrsn
davidpdrsn commented Dec 30, 2023
View reviewed changes
@davidpdrsn davidpdrsn added the breaking change A PR that makes a breaking change. label Dec 30, 2023
@davidpdrsn davidpdrsn marked this pull request as ready for review December 30, 2023 21:35
@davidpdrsn davidpdrsn requested a review from jplatte December 30, 2023 21:35
jplatte
jplatte approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, diff doesn't even look that complicated ^^

@davidpdrsn davidpdrsn mentioned this pull request Dec 30, 2023
Closed
2 tasks
@jplatte jplatte mentioned this pull request Jan 2, 2024
Merged
@jplatte jplatte force-pushed the david/sync-services branch from 2ac8a1e to ad79d56 Compare March 14, 2024 20:49
andersk
andersk reviewed Mar 14, 2024
View reviewed changes
@jplatte jplatte force-pushed the david/sync-services branch from ad79d56 to 5b316eb Compare March 14, 2024 23:15
@jplatte jplatte requested a review from mladedav September 28, 2024 11:09
@jplatte jplatte merged commit 52fd139 into main Sep 28, 2024
18 checks passed
@jplatte jplatte deleted the david/sync-services branch September 28, 2024 21:28
@jplatte jplatte mentioned this pull request Sep 28, 2024
Merged
@jsbaudler jsbaudler mentioned this pull request Jan 1, 2025
Closed
@rubdos rubdos mentioned this pull request Jan 2, 2025
Closed
@syphar syphar mentioned this pull request Jan 3, 2025
Closed
@dnlsndr dnlsndr mentioned this pull request Jan 4, 2025
Merged
@AzureMarker AzureMarker mentioned this pull request Jan 12, 2025
Merged
@vsiles vsiles mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

@mladedav mladedav mladedav approved these changes

+1 more reviewer

@andersk andersk andersk left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
breaking change A PR that makes a breaking change.
Projects
None yet
Milestone
0.8
Development

Successfully merging this pull request may close these issues.

Should we require Sync for services?
4 participants
@davidpdrsn @andersk @jplatte @mladedav