Remove B type param: the rest
#1778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
commented
Feb 21, 2023
| let service = tower::ServiceExt::<Request<Body>>::map_err( | ||
| handle_404.into_service(), | ||
| |err| -> std::io::Error { match err {} }, | ||
| ); |
There was a problem hiding this comment.
Hm having to specificy the types like this is pretty unfortunate 😕 but otherwise we get inference errors.
There was a problem hiding this comment.
Feels like between this and the middleware-state thing, tower not receiving nearly as much attention as axum is becoming a problem...
2 tasks
jplatte
reviewed
Feb 28, 2023
| S: Send + Sync, | ||
| { | ||
| type Rejection = (); | ||
|
|
||
| async fn from_request(_req: Request<B>, _state: &S) -> Result<Self, Self::Rejection> { | ||
| async fn from_request(_req: Request<axum::body::Body>, _state: &S) -> Result<Self, Self::Rejection> { |
There was a problem hiding this comment.
Not yet. That comes in #1789
| let service = tower::ServiceExt::<Request<Body>>::map_err( | ||
| handle_404.into_service(), | ||
| |err| -> std::io::Error { match err {} }, | ||
| ); |
There was a problem hiding this comment.
Feels like between this and the middleware-state thing, tower not receiving nearly as much attention as axum is becoming a problem...
jplatte
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should all compile now 🤞