riscv: more llvm_asm --> asm #2319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
bradjc
reviewed
Jan 5, 2021
| : | ||
| : | ||
| : "volatile"); | ||
| unreachable_unchecked() |
There was a problem hiding this comment.
Did you intend to remove this?
There was a problem hiding this comment.
yes. Applying the noreturn option should have the same effect -- it tells the compiler that we can never fall out of the asm block.
bradjc
previously approved these changes
Jan 5, 2021
alistair23
previously approved these changes
Jan 5, 2021
hudson-ayers
commented
Jan 5, 2021
5024b6d to
3ed7879
Compare
|
whoops, I thought that import was unused bc I missed the gap in the diff. I put it back to how it was before. |
bradjc
previously approved these changes
Jan 5, 2021
|
bors r+ |
|
Merge conflict. |
|
bors r+ |
bradjc
previously approved these changes
Jan 8, 2021
77e54c9 to
274d38c
Compare
|
Canceled. |
|
rebased to fix merge conflict |
bradjc
approved these changes
Jan 8, 2021
|
bors r+ |
|
Build failed:
|
|
the bors macos build was cancelled bc the mac github actions are finicky but everything else passed so I am going to manually merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request converts several more uses of llvm_asm --> asm, for a few risc-v platforms. I specifically chose the instances contained within
#[naked]functions, which are disallowed in newer versions of rustc.Testing Strategy
This pull request was tested by compiling only!
TODO or Help Wanted
testing plz
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.