-
-
Notifications
You must be signed in to change notification settings - Fork 768
Board based instantiation of chip drivers and interrupt mappings: Msp432 #2189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sure, no problem! |
I ran now a couple of test programs (blink, button, helloworld, ipc, etc.) , and everything seems to work fine. However, I stumbled across a different problem which might be a bug in the linking-stage or within the kernel-linker-script. When I run
Initially I thought maybe pub static mut TEST: usize = 334;
unsafe fn startup_intilialisation() {
msp432::init();
TEST += 1;
...
} I get the following output:
So obviously |
If by "end up in the binary" you mean "ends up in flash" I don't think that is happening. The GNU-size utility used to print the size information says the following:
So I think we are seeing exactly what we should expect. |
Ok, thanks for the answer! I am still a bit confused about this because when flashing the binary with openocd it always prints the amount of flashed bytes. And this number equals exactly the decimal or hexadecimal column. But it's not a big problem, I'll try to find the problem when I have time (: |
bors d+ |
✌️ hudson-ayers can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
89b7708
to
bec4776
Compare
rebased to resolve conflicts |
bec4776
to
f336a75
Compare
Will this PR be merged in the near future? Because I have some fixes pending for this platform but I thought it doesn't make sense to open a PR before this one isn't merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Timed out. |
bors retry |
Timed out. |
bors r+ |
Pull Request Overview
This pull request ports the MSP432 chip/board to the new peripheral instantiation approach that does not rely on global variables (first proposed in #2069).
This chip was relatively easy to change compared to some of the others, but @lebakassemmerl I would still appreciate a quick look over the changes or a test of a couple apps to ensure I haven't done anything stupid.
This is the last remaining chip before all upstream chips/boards have been ported!
Testing Strategy
This pull request was tested by compiling, hardware testing would be nice.
TODO or Help Wanted
N/A
Documentation Updated
/docs
, or no updates are required.Formatting
make prepush
.