-
-
Notifications
You must be signed in to change notification settings - Fork 768
Update Nightly to Feb 2022 #2959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `asm!()` macro was stabilized in rust-lang/rust#91728. This removes the feature and imports it through `core::arch` instead.
3875a3f
to
6b34875
Compare
63ceed0
to
b11b12a
Compare
b11b12a
to
dab6ffa
Compare
hudson-ayers
approved these changes
Feb 28, 2022
alistair23
approved these changes
Feb 28, 2022
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 4, 2022
2959: Update Nightly to Feb 2022 r=hudson-ayers a=bradjc ### Pull Request Overview The headline here being: `asm!()` is stabilized! (As of rust-lang/rust#91728.) Most changes are to remove the asm feature and add `use core::arch:asm`. ### Testing Strategy travis ### TODO or Help Wanted Resolved: ~~Can someone look at https://github.com/tock/tock/compare/update-nightly-feb-2022?expand=1#diff-494cb9c3b94f58f1ab43cca69f63906088f87a97726d9260665f8529f605f2c9L259? I had to remove some clobbers to remove an error. I think that is ok (https://stackoverflow.com/questions/41380345/how-to-use-hir8-r12-register-in-cortex-m0) but I'm not sure.~~ ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Brad Campbell <bradjc5@gmail.com>
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
risc-v
RISC-V architecture
stm32
Change pertains to the stm32 family of MCUSs
tock-libraries
This affects libraries supported by the Tock project
WG-OpenTitan
In the purview of the OpenTitan working group.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
The headline here being:
asm!()
is stabilized! (As of rust-lang/rust#91728.) Most changes are to remove the asm feature and adduse core::arch:asm
.Testing Strategy
travis
TODO or Help Wanted
Resolved:
Can someone look at https://github.com/tock/tock/compare/update-nightly-feb-2022?expand=1#diff-494cb9c3b94f58f1ab43cca69f63906088f87a97726d9260665f8529f605f2c9L259? I had to remove some clobbers to remove an error. I think that is ok (https://stackoverflow.com/questions/41380345/how-to-use-hir8-r12-register-in-cortex-m0) but I'm not sure.Documentation Updated
/docs
, or no updates are required.Formatting
make prepush
.