Skip to content

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Feb 9, 2022

Pull Request Overview

The headline here being: asm!() is stabilized! (As of rust-lang/rust#91728.) Most changes are to remove the asm feature and add use core::arch:asm.

Testing Strategy

travis

TODO or Help Wanted

Resolved: Can someone look at https://github.com/tock/tock/compare/update-nightly-feb-2022?expand=1#diff-494cb9c3b94f58f1ab43cca69f63906088f87a97726d9260665f8529f605f2c9L259? I had to remove some clobbers to remove an error. I think that is ok (https://stackoverflow.com/questions/41380345/how-to-use-hir8-r12-register-in-cortex-m0) but I'm not sure.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@github-actions github-actions bot added risc-v RISC-V architecture stm32 Change pertains to the stm32 family of MCUSs tock-libraries This affects libraries supported by the Tock project WG-OpenTitan In the purview of the OpenTitan working group. labels Feb 9, 2022
@bradjc bradjc mentioned this pull request Feb 9, 2022
29 tasks
@bradjc bradjc added the blocked Waiting on something, like a different PR or a dependency. label Feb 10, 2022
The `asm!()` macro was stabilized in
rust-lang/rust#91728. This removes the feature
and imports it through `core::arch` instead.
@bradjc bradjc force-pushed the update-nightly-feb-2022 branch from 3875a3f to 6b34875 Compare February 25, 2022 15:59
@bradjc bradjc removed the blocked Waiting on something, like a different PR or a dependency. label Feb 25, 2022
@bradjc bradjc force-pushed the update-nightly-feb-2022 branch 3 times, most recently from 63ceed0 to b11b12a Compare February 25, 2022 19:05
@bradjc bradjc force-pushed the update-nightly-feb-2022 branch from b11b12a to dab6ffa Compare February 25, 2022 19:30
@hudson-ayers
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Mar 4, 2022
2959: Update Nightly to Feb 2022 r=hudson-ayers a=bradjc

### Pull Request Overview

The headline here being: `asm!()` is stabilized! (As of rust-lang/rust#91728.) Most changes are to remove the asm feature and add `use core::arch:asm`.


### Testing Strategy

travis


### TODO or Help Wanted

Resolved: ~~Can someone look at https://github.com/tock/tock/compare/update-nightly-feb-2022?expand=1#diff-494cb9c3b94f58f1ab43cca69f63906088f87a97726d9260665f8529f605f2c9L259? I had to remove some clobbers to remove an error. I think that is ok (https://stackoverflow.com/questions/41380345/how-to-use-hir8-r12-register-in-cortex-m0) but I'm not sure.~~


### Documentation Updated

- [x] Updated the relevant files in `/docs`, or no updates are required.

### Formatting

- [x] Ran `make prepush`.


Co-authored-by: Brad Campbell <bradjc5@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 4, 2022

This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried.

@bors
Copy link
Contributor

bors bot commented Mar 4, 2022

@bors bors bot merged commit af4c24f into master Mar 4, 2022
@bors bors bot deleted the update-nightly-feb-2022 branch March 4, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
risc-v RISC-V architecture stm32 Change pertains to the stm32 family of MCUSs tock-libraries This affects libraries supported by the Tock project WG-OpenTitan In the purview of the OpenTitan working group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants