Skip to content

client: conditionally add proxy when using node.js web socket library #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

client: conditionally add proxy when using node.js web socket library #209

wants to merge 1 commit into from

Conversation

richard-cox
Copy link

If using the node.js web socket library check the env for proxy variables. If found and applicable apply.

Note - This would add an additional dependency to https-proxy-agent.

@AlcaDesign AlcaDesign closed this Feb 6, 2019
Tiger6201
Tiger6201 reviewed Mar 29, 2019
View reviewed changes
Copy link

@Tiger6201 Tiger6201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit should be add to the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Tiger6201 Tiger6201 Tiger6201 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-cox @Tiger6201 @AlcaDesign