Skip to content

translate to korean #4479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

translate to korean #4479

wants to merge 5 commits into from

Conversation

nayounsang
Copy link
Contributor

Describe what your pull request does. If you can, add GIFs or images showing the before and after of your change.

Change type

  • bugfix
  • improvement
  • feature
  • api
  • other

Test plan

  • Unit tests
  • End to end tests

Release notes

#4474
I translates keys that have not yet been translated into Korean.
assets/translations/ko-kr.json.
This is part of result.
image

@huppy-bot huppy-bot bot added improvement Product improvement other Changes that don't affect SDK users, e.g. internal or .com changes labels Sep 10, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 10, 2024

@nayounsang is attempting to deploy a commit to the tldraw Team on Vercel.

A member of the Team first needs to authorize it.

@huppy-bot
Copy link
Contributor

huppy-bot bot commented Sep 10, 2024 •
edited
Loading

nayounsang has signed the Contributor License Agreement. Thanks!

@nayounsang
Copy link
Contributor Author

I have read and agree to the Contributor License Agreement.

@nayounsang nayounsang mentioned this pull request Sep 10, 2024
Closed
1 task
@SomeHats SomeHats requested a review from TodePond September 10, 2024 13:02
@mimecuvalo
Copy link
Member

Thanks for your PR @nayounsang!
We actually handle our localization on an app called Lokalise.

Can you reach out to me mime@tldraw.com with your email address? I will add you to the project so that you can make the changes there. Thank you!

@nayounsang
Copy link
Contributor Author

@mimecuvalo
I sent an email with nayounsang722@gmail.com

@mimecuvalo
Copy link
Member

Thank you! You've been invited.

@nayounsang
Copy link
Contributor Author

nayounsang commented Sep 11, 2024 •
edited
Loading

@mimecuvalo I finished it in Lokalise.
Is there anything else I need to do for the changes to take effect?

@TodePond
Copy link
Collaborator

@nayounsang amazing, thank you! I'll trigger a PR from Lokalise now to pull the changes through :)

@TodePond
Copy link
Collaborator

Merging these changes in this PR: #4498
Thanks again!

@TodePond TodePond closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TodePond TodePond Awaiting requested review from TodePond

Assignees
No one assigned
Labels
improvement Product improvement other Changes that don't affect SDK users, e.g. internal or .com changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nayounsang @mimecuvalo @TodePond