Skip to content

Use built-in conversions for primitive <-> byte array conversions. #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2025
Merged

Use built-in conversions for primitive <-> byte array conversions. #256

merged 1 commit into from
May 4, 2025

Conversation

briansmith
Copy link
Contributor

Avoid transmutes. This is a step towards removing all transmutes from convert.rs.

@briansmith briansmith mentioned this pull request Feb 27, 2025
Open
@tkaitchuck
Copy link
Owner

Change looks fine, but I can't merge due to conflicts.

@briansmith
Use built-in conversions for primitive <-> byte array conversions.
ada3630 
Avoid transmutes. This is a step towards removing all transmutes from
convert.rs.
@briansmith
Copy link
Contributor Author

Change looks fine, but I can't merge due to conflicts.

Thanks. I updated the changes. However, now the no_std build fails because, apparently, the unstable start feature that it uses has been removed. I will update this PR after that has been fixed as I don't have time to investigate a solution for that problem.

@tkaitchuck tkaitchuck merged commit 0b8488e into tkaitchuck:master May 4, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkaitchuck tkaitchuck tkaitchuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briansmith @tkaitchuck