Allow projects to be blacklisted for tips. #163
Conversation
|
this feature could also be extended to include a contributor blacklist |
|
If you invert this you can, and probably should, use it as an opt-in system instead by maintaining a whitelist of the URLs. If projects want to be able to receive tips then they have to submit a PR to add their projects to the whitelist. I'm happy to flip the logic to make it a whitelist, however, this will effectively remove all existing projects. I'll leave that decision up to the maintainers. |
|
I don't agree with this feature at all. Should a project maintainer have a say in what other members of the project decide to do with the money being offered to them? It's much better to just have an easy method to unsubscribe from emails for individual contributors. |
Allow projects to be blacklisted for tips.
@bearbin individual contributors always had this feature though now it doesn't make sense since we don't send out emails anymore @adamtanner , thanks for your contribution! (I personally think it is wrong to prevent free cooperation of people, but since project maintainers do really complain about it, we need to address it) |
Allow authors to submit PRs to include their projects in the blacklist.yml to prevent them from accepting tips. By using a YAML file checked into Git we can propagate the blacklist to forks as well.
More work needs to be done to provide a cleanup routine for existing projects that have since been blacklisted to return funds, mark project as disabled, etc. Someone with more domain knowledge should pick this up.
Ultimately this should be an opt-in system only, but that will require more time than I have to give. I hope this is a step in the right direction.
Fixes: #127, #145, #149, #150, #153, #155, #158, #159, #161, #162, #164, #166
Related: #146, #154, #157