Skip to content

fix: change Volcano response Extra type from String to Dictionary #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

tisfeng
Copy link
Owner

@tisfeng tisfeng commented Apr 8, 2025

Fix Volcano Translate error.

It seems that the structure of the Volcano Translate response has changed. Previously, Extra was a String, but now it is a Dictionary.

Volcano Docs is too bad 😡

{
  "TranslationList": [
    {
      "Translation": "",
      "DetectedSourceLanguage": "",
      "Extra": { "input_characters": "4", "source_language": "en" }
    }
  ],
  "ResponseMetadata": {
    "RequestId": "20250408103303ED54F9E8A6CC5E8853D6",
    "Action": "TranslateText",
    "Version": "2020-06-01",
    "Service": "translate",
    "Region": "cn-north-1"
  }
}

Now
image

Fixed

image

Copy link
Collaborator

@Jerry23011 Jerry23011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisfeng tisfeng merged commit 2001d9c into dev Apr 9, 2025
5 checks passed
@tisfeng tisfeng deleted the fix-volcano-translate branch April 9, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants