refactor: rewrite screenshot feature with Swift #846
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New screenshot feature may be unstable, so we only enable it in beta mode. If it works well, we will release it to all users in next version. |
This was referenced Mar 22, 2025
Open
|
我准备发布一个新版本，就先合并了，稍后如果发现问题，我们再来修复。 |
auto-merge was automatically disabled
March 23, 2025 14:06
Pull request was closed
bd64edd to
fe377c6
Compare
|
奇怪，我明明本地合并了 refactor-screenshot 分支，推送远程也成功了 6e32061 ，为什么这里 GitHub UI 没有显示合并成功，反而自动关闭了？ |
|
是不是本地直接merge到dev然后推上来了？如果是的话，可能因为PR跟dev没有diff所以自动关闭了？ |
|
我之前也这样做过，直接本地将 PR 分支合并到 dev，然后推送 dev，此时 GitHub 上的 PR 会显示成功合并状态 #830 ，我怀疑 GitHub 偷偷更改了这个合并显示逻辑。。 |
|
有可能 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #22 , #595 , #736 , #461
#81
Support clicking D to select the last screenshot area.