Skip to content

Adapt new youdao api jsonapi_s #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 9, 2025
Merged

Conversation

Rick630
Copy link
Contributor

@Rick630 Rick630 commented Jan 5, 2025

接入新有道API #772 (comment)

@Rick630 Rick630 changed the base branch from main to dev January 5, 2025 16:24
@Rick630 Rick630 marked this pull request as draft January 5, 2025 16:37
@Rick630 Rick630 marked this pull request as ready for review January 6, 2025 03:18
@Rick630 Rick630 mentioned this pull request Jan 6, 2025
@Rick630 Rick630 closed this Jan 8, 2025
@Rick630 Rick630 deleted the feature/new_youdao_api branch January 8, 2025 11:13
@Rick630 Rick630 restored the feature/new_youdao_api branch January 8, 2025 11:14
@Rick630 Rick630 reopened this Jan 8, 2025
@tisfeng
Copy link
Owner

tisfeng commented Jan 8, 2025

我注意到新接口,有些查询结果和之前的显示不一样,请检查一下。

我们应尽量保持前后接口数据一致,以及和有道官网的界面显示同步。

请多测试一些数据,包括中英文单词,短语等。

image

@Rick630
Copy link
Contributor Author

Rick630 commented Jan 8, 2025

我注意到新接口,有些查询结果和之前的显示不一样,请检查一下。

我们应尽量保持前后接口数据一致,以及和有道官网的界面显示同步。

请多测试一些数据,包括中英文单词,短语等。

image

感谢提醒,有部分些结构不一样,已经改正了

@Rick630 Rick630 requested a review from tisfeng January 9, 2025 03:44
tisfeng
tisfeng previously approved these changes Jan 9, 2025
Copy link
Owner

@tisfeng tisfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,看起来没什么问题了。

@tisfeng tisfeng merged commit fc05e88 into tisfeng:dev Jan 9, 2025
4 checks passed
@tisfeng
Copy link
Owner

tisfeng commented Jan 9, 2025

感谢 PR,如果后续有其他想要改进的地方,欢迎继续 PR。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants