feat!: esm-only #253
Merged
feat!: esm-only #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves to being esm-only. Unlike other tinylib projects, this one keeps `tsup` since we bundle dependencies still. If we ever decide not to bundle dependencies, we should drop tsup and ship the typescript emit as-is.
commit: |
size-limit report 📦
|
|
Thanks, the CI action checking the size also needs CJS handling removal. |
|
Any idea how we can make it happy? It seems confused since we removed a file |
It's not a file removal, it's an action configuration cleanup. I can take over the PR since it a branch on the upstream GitHub repo. |
|
Interesting. For future reference, where does that live? Edit: Found it! Feel free to update it, otherwise I will when I'm next at my laptop 👍 |
|
i've updated the config 👍 still waiting on the other tinylibs repos anyway so lets coordinate releases on discord |
jerome-benoit
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves to being esm-only.
Unlike other tinylib projects, this one keeps
tsupsince we bundle dependencies still.If we ever decide not to bundle dependencies, we should drop tsup and ship the typescript emit as-is.