Skip to content
This repository was archived by the owner on Apr 2, 2024. It is now read-only.

Conversation

harkishen
Copy link
Member

@harkishen harkishen commented Mar 24, 2022

Signed-off-by: Harkishen-Singh harkishensingh@hotmail.com

Fixes: #1239

After the fix, the metric now looks like

image

Merge requirements

Please take into account the following non-code changes that you may need to make with your PR:

  • CHANGELOG entry for user-facing changes
  • Updated the relevant documentation

@harkishen harkishen self-assigned this Mar 24, 2022
@harkishen harkishen force-pushed the fix_max_sent_timestamp_metric branch from 5dec28d to e29264f Compare March 24, 2022 14:25
@harkishen harkishen requested a review from a team as a code owner March 24, 2022 14:25
@harkishen harkishen force-pushed the fix_max_sent_timestamp_metric branch from e29264f to c8de6f4 Compare March 24, 2022 14:47
@antekresic antekresic self-requested a review March 30, 2022 10:11
@harkishen harkishen force-pushed the fix_max_sent_timestamp_metric branch 2 times, most recently from 5879673 to abd333e Compare March 30, 2022 10:32
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
@harkishen harkishen force-pushed the fix_max_sent_timestamp_metric branch from abd333e to 5d86a4a Compare March 30, 2022 10:46
@harkishen harkishen enabled auto-merge (rebase) March 30, 2022 10:48
Copy link
Contributor

@niksajakovljevic niksajakovljevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic needs to be reversed

@harkishen harkishen merged commit d7aa13e into timescale:master Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect values for promscale_ingest_max_sent_timestamp_milliseconds metric
3 participants