This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Register promscale_ingest_channel_len metric and make it a Gauge.
#1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/pgmodel/ingestor/copier.go
Outdated
| samplesCopierChannelToMonitor chan readRequest | ||
| // Declare and register here since we need readRequest struct which should not be defined in | ||
| // pgmodel/metric. | ||
| ingestorChannelLenCopier = prometheus.NewGaugeFunc( |
There was a problem hiding this comment.
I failed to understand why can't we just have one gauge metric IngestorChannelLen (defined in ingest.go) and use it for both batcher and copier with different label values? That approach would make it for less code and would not require to have a global var samplesCopierChannelToMonitor
There was a problem hiding this comment.
There was a problem hiding this comment.
The recent commit updates this. But basically, one metric (copier channel_len) needs a callback to be updated when prometheus pings the /metric (hence we need NewGaugeFunc), and the other done for metric batcher will be used irrespective of prometheus calls (so NewGauge will work).
440b5a7 to
11dcae3
Compare
antekresic
approved these changes
Feb 21, 2022
11dcae3 to
8715201
Compare
niksajakovljevic
approved these changes
Feb 21, 2022
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
8715201 to
07a5f03
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harkishen-Singh harkishensingh@hotmail.com
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: