fix: store ModelRequest in generate_sql messages list #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69f0a35 to
713ac79
Compare
713ac79 to
c1b9fd1
Compare
Signed-off-by: Matthew Peveler <mpeveler@timescale.com>
c1b9fd1 to
61a96ed
Compare
jgpruitt
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR modifies the
GenerateSQLResponse.messagesvalue such that it's now alist[tuple[ModelRequest, ModelResponse]], so that we capture both the request to the model as well as its response, where previously we were just capturing the response. This should make introspection of the generate process easier.As part of this, I removed the
GenerateSQLResponse.final_promptvalue as this is just a duplicate of the finalModelRequestobject that we have in the messages list.