Skip to content

test: add upgrade tests for pgai lib #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

test: add upgrade tests for pgai lib #826

merged 1 commit into from
Jun 25, 2025

Conversation

smoya
Copy link
Contributor

@smoya smoya commented Jun 17, 2025 •
edited
Loading

No description provided.

@smoya smoya temporarily deployed to internal-contributors June 17, 2025 10:33 — with GitHub Actions Inactive
@smoya smoya force-pushed the smoya/pga-11-create-upgrade-tests-for-pgai-lib branch from bb92135 to bf6ce09 Compare June 19, 2025 12:59
@smoya smoya temporarily deployed to internal-contributors June 19, 2025 12:59 — with GitHub Actions Inactive
@smoya smoya force-pushed the smoya/pga-11-create-upgrade-tests-for-pgai-lib branch from bf6ce09 to 234bad9 Compare June 19, 2025 13:47
@smoya smoya temporarily deployed to internal-contributors June 19, 2025 13:47 — with GitHub Actions Inactive
@smoya smoya marked this pull request as ready for review June 19, 2025 13:47
@smoya smoya requested a review from a team as a code owner June 19, 2025 13:47
@smoya smoya force-pushed the smoya/pga-11-create-upgrade-tests-for-pgai-lib branch from 234bad9 to 676cd99 Compare June 19, 2025 13:51
@smoya smoya temporarily deployed to internal-contributors June 19, 2025 13:51 — with GitHub Actions Inactive
@smoya smoya force-pushed the smoya/pga-11-create-upgrade-tests-for-pgai-lib branch from 676cd99 to a2abd42 Compare June 19, 2025 13:55
@smoya smoya temporarily deployed to internal-contributors June 19, 2025 13:55 — with GitHub Actions Inactive
@alejandrodnm
Copy link
Contributor

Should we keep the latest state in version control? That's being my experience with working with snapshots, that way you can see the changes that are being added.

I can see the operation burden turning into a pain point for us. I'm not advocating either approach.

@alejandrodnm
Copy link
Contributor

@smoya rebase main to fix the broken test.

@smoya smoya force-pushed the smoya/pga-11-create-upgrade-tests-for-pgai-lib branch from a2abd42 to 53b8ca3 Compare June 20, 2025 14:13
@smoya smoya temporarily deployed to internal-contributors June 20, 2025 14:13 — with GitHub Actions Inactive
@smoya
Copy link
Contributor Author

smoya commented Jun 20, 2025

Should we keep the latest state in version control? That's being my experience with working with snapshots, that way you can see the changes that are being added.

Can be a good thing, however my concern is that we will forgot at some point untracking old versioned files. So mixed feelings. WDYT?

@smoya smoya force-pushed the smoya/pga-11-create-upgrade-tests-for-pgai-lib branch from 53b8ca3 to 98d8b6e Compare June 20, 2025 14:22
@smoya smoya temporarily deployed to internal-contributors June 20, 2025 14:22 — with GitHub Actions Inactive
@smoya smoya mentioned this pull request Jun 20, 2025
Open
@smoya smoya force-pushed the smoya/pga-11-create-upgrade-tests-for-pgai-lib branch from 98d8b6e to 8776633 Compare June 20, 2025 19:05
@smoya smoya temporarily deployed to internal-contributors June 20, 2025 19:05 — with GitHub Actions Inactive
@smoya smoya force-pushed the smoya/pga-11-create-upgrade-tests-for-pgai-lib branch from 8776633 to bc1f172 Compare June 20, 2025 19:05
@smoya smoya temporarily deployed to internal-contributors June 20, 2025 19:05 — with GitHub Actions Inactive
@smoya smoya force-pushed the smoya/pga-11-create-upgrade-tests-for-pgai-lib branch from bc1f172 to 405686c Compare June 20, 2025 19:08
@smoya smoya temporarily deployed to internal-contributors June 20, 2025 19:08 — with GitHub Actions Inactive
@smoya smoya merged commit 17eaef2 into main Jun 25, 2025
15 checks passed
@smoya smoya deleted the smoya/pga-11-create-upgrade-tests-for-pgai-lib branch June 25, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrodnm alejandrodnm alejandrodnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smoya @alejandrodnm