chore: split deps into separate extras #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
reviewed
Jun 10, 2025
docs/semantic_catalog/quickstart.md
Outdated
| @@ -92,7 +92,7 @@ Once the semantic catalog is loaded with embedded descriptions, you start genera | |||
| ```bash | |||
| git clone https://github.com/timescale/pgai.git -b jgpruitt/semantic-catalog | |||
| cd pgai/projects/pgai | |||
| uv sync | |||
| uv sync --all-extras | |||
There was a problem hiding this comment.
nah you're right just semantic-catalog is enough.
cb8cbed to
20d13fa
Compare
20d13fa to
f26c831
Compare
|
I like the change so far. |
f26c831 to
e996bc1
Compare
|
@smoya @JamesGuthrie Do you think we should proceed with this? If yes, what is missing? |
alejandrodnm
approved these changes
Jun 17, 2025
smoya
approved these changes
Jun 19, 2025
Happy proceeding 👍 |
JamesGuthrie
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the worker and semantic-catalog into 2 separate extras. This setup would allow to install pgai via
pip install pgaiand use it to install all the SQL viapgai install -d ...If then you try to run
pgai vectorizer workeryou'll get an error:Same for any semantic catalog command.
The error messages use rich and tiktoken to decide if the extra was installed, since it is non-trivial/not cleanly possible to determine if an extra is installed, pip doesn't really store this metadata.
Note: This PR does unintentionally update a bunch of dependencies. I don't really know how to prevent that since uv doesn't have a command to move an existing dependency between extras. Since tests still pass I think we are fine though.