ci: install pgai when running dev env through compose-dev.yaml #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
commented
May 7, 2025
| for i in $(seq 1 10); do | ||
| echo "Attempt $$i: installing pgai..." | ||
| # always overwriting previous installation here. | ||
| python -m pgai install -d postgres://postgres:postgres@db:5432/postgres && exit 0 |
There was a problem hiding this comment.
Not using --strict here as this is a dev env.
4a80edb to
a7acfbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't update the
compose-dev.yamlfile since the repackaging. That means we were not installingpgaiin the DB and we were still asking the user to install the extension.Additionally, we were using the wrong postgres PGDATA path. In particular, we were setting
/home/postgres/pgdata/datainstead of the default in postgres/var/lib/postgresql/databecause is the one we use in timescaledb-docker-ha.That means data was never persisted in the host volume.