-
Notifications
You must be signed in to change notification settings - Fork 278
test: use pgai-db container instead of pgai-ext for db tests #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests were designed to work with the build.py in the projects/pgai/db directory which creates a pgai-ext
container. In CI, we use the pgai-ext
container for all of these tests. If we want to change any of this, we should consider the whole setup.
I see it builds and runs pgai/projects/pgai/db/build.py Lines 180 to 198 in 6daa502
|
Weird. CI still references the I think we should consider a more comprehensive cleanup of this |
But we use it in CI only for the |
Dismissing my review. Someone else take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't taken a very deep loop at this, but at the surface level it looks right.
I suspect that when we copy-pasted these files from the extension repository when setting up projects/pgai/db, we didn't change pgai-ext
to pgai-db
.
This isn't surfaced in CI because it runs everything in docker, so these paths are never hit.
No description provided.