Revert "Drop obsolete go collector in favor of controller-runtime" #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ba4de9f.
timebertt
added a commit
that referenced
this pull request
Jun 24, 2025
…499) This reverts commit 9f48634. Breaking back-and-forth in controller-runtime. This adapts to kubernetes-sigs/controller-runtime#3070
timebertt
added a commit
that referenced
this pull request
Jun 24, 2025
* Update k8s packages * `go work use && make tidy` * Silence deprecation warning * Reapply "Drop obsolete go collector in favor of controller-runtime" (#499) This reverts commit 9f48634. Breaking back-and-forth in controller-runtime. This adapts to kubernetes-sigs/controller-runtime#3070 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tim Ebert <timebertt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This reverts commit ba4de9f (part of #469), because of a breaking back-and-forth change in controller-runtime v0.20.2/v0.20.3.
ref #498
ref kubernetes-sigs/controller-runtime#3144
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: