portforward: Allow websockets to be used for port-forwarding #6569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf00d45 to
81bec1d
Compare
Signed-off-by: Andrew Hamilton <ahamilton55@gmail.com>
81bec1d to
0445003
Compare
|
@nicks This test failed in CI but it doesn't really seem to be related to the change. I tried running it again but it failed again. I ran the tests locally and they all passed so I'm not sure what the issue is. |
nicks
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of port-forwarding only supports the spdy protocol. Newer API servers can handle websockets and fall back to spdy if they aren't available.
This updates the code to use websockets for port forwarding when available and to fall back to spdy if it needs to.
This is pretty much the same way that the
kubectl port-forwardcommand handles this situation.Fixes #6568.