liveupdate: always update k8s clusters with kubectl exec #6535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a fun deep dive into the history of Tilt and Kubernetes file-syncing When Tilt was first written, there weren't well-established conventions for how to sync a file to a cluster. There were disagreements about whether this was a "user-space" operation or a "privileged" operation, and what permissions a file should get when it's written. Over the years, all that's settled down: the k8s community has invested a lot in having a robust, streaming exec endpoint, and using that for all file copying. (a similar convergence has happened on the container runtime side -- everything has consolidated on the docker exec endpoint, rather than separate file-copying endpoints) with that in mind, let's simplify things even more and use kubectl exec endpoint, even when we have direct access to the container runtime. this fixes the case when Docker Desktop is using separate container runtimes that share an image store. fixes #6533 Signed-off-by: Nick Santos <nick.santos@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a fun deep dive into the history of Tilt
and Kubernetes file-syncing
When Tilt was first written, there weren't well-established
conventions for how to sync a file to a cluster. There
were disagreements about whether this was a "user-space"
operation or a "privileged" operation, and what permissions
a file should get when it's written.
Over the years, all that's settled down: the k8s community
has invested a lot in having a robust, streaming exec
endpoint, and using that for all file copying.
(a similar convergence has happened on the container runtime
side -- everything has consolidated on the docker exec
endpoint, rather than separate file-copying endpoints)
with that in mind, let's simplify things even more
and use kubectl exec endpoint, even when we have direct
access to the container runtime.
this fixes the case when Docker Desktop is using
separate container runtimes that share an image store.
fixes #6533
Signed-off-by: Nick Santos nick.santos@docker.com