store: update how we model file changes #6503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c690eb to
3a86073
Compare
before this PR, we kept a map of recent file changes, and deleted from the map when the changes were consumed. this creates race conditions if the events are processed in a different order than the changes, e.g., if a "consumed" event at 12:02 is processed before the file change event at 12:01. after this PR, we record both the file change time and the consumed time, then compare them to determine if the file change is still pending. Signed-off-by: Nick Santos <nick.santos@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this PR, we kept a map of recent file changes,
and deleted from the map when the changes were consumed.
this creates race conditions if the events are processed
in a different order than the changes, e.g.,
if a "consumed" event at 12:02 is processed before
the file change event at 12:01.
after this PR, we record both the file change time
and the consumed time, then compare them to determine
if the file change is still pending.
Signed-off-by: Nick Santos nick.santos@docker.com