fix (Tiltfile) stuck in pending state #6493
Conversation
|
I will note I'm not that familiar with the code base, so Sorry if there is an implication I'm missing with this change, or a better way to address the issue. I will also note I think there is another race still present, but only impacting the Status as reported to the UI. The WebUI will show the (Tiltfile) status as pending, even though it has actually processed all the pending filesystem events. I don't believe it's caused by the same problem as this PR, but wanted to mention it just in case I'm missing something. |
Signed-off-by: Kevin Nisbet <kevin@spirl.com>
27fc8de to
668d93e
Compare
|
Thanks for sending this change - I think this is the right change conceptually, but is also a fairly low-level change, and need some time to test out some cases I'm worried about. |
Sure thing. Feel free to tag me if I need to revise anything, and feel free to throw this out if you see a better way to fix the issue. |
Fixes #5902
I was having the same issue described in #5902 where when using filesystem triggers to add or remove resources, it would sometimes race and leave the Tiltfile in the pending status without the most recent state.
I believe I successfully tracked this down to the filewatch controller when reconciled can replace the watcher object with a new configuration, but doesn't preserve previous file events when doing so. This can then race with the Reconcile on the tiltfile to miss that there is a pending filesystem change and instead see an empty list of filesystem changes (
tilt/internal/controllers/core/tiltfile/reconciler.go
Lines 235 to 240 in 59f9aa2