Defer registry lookup until after Tiltfile is loaded #5184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
approved these changes
Nov 17, 2021
internal/tiltfile/tiltfile_state.go
Outdated
| } | ||
|
|
||
| // Defer lookup of registry until now | ||
| if s.localRegistry == nil { |
There was a problem hiding this comment.
for what it's worth - i'm pretty sure LocalRegistry() is already memoized in the k8sClient itself, so no need to store it as a field on tiltfileState
There was a problem hiding this comment.
Yeah, I wasn't sure whether it made sense to keep that struct field. I'm going to remove and clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When only using docker compose as in #4882, looking up the registry is unnecessary and appears to block the UI until after the tiltfile is fully executed.