Upgrade to matrix-android-sdk 0.9.14. #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a bunch of changes, required, to move to the latest SDK: 1. Update AAR's. The matrix-sdk.aar in this commit was built from the v0.9.14 tag of the matrix-android-sdk git repository. olm-sdk.jar is pulled from the same place. 2. Updates to the build scripts. matrix-android-sdk added kotlin as a dependency, moved to okhttp3, added io.realm, and so on. 3. Code modifications to support new SDK itself. The changes, here, are a grab bag, and you're best off just reading the commit. Of particular note, here, is that LoginRestClient.loginWithUser takes a device name *and* a device ID, now (the previous API only took a device name). As a wicked had, right now, I'm just using the name as the ID, but I have no doubt that's wrong and this should be cleaned up to include a randomly generated, persisted device ID, as I believe this is used by Synapse to track login sessions.
|
Thanks for this merge request! Sorry it took so long to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bunch of changes, required, to move to the latest SDK:
Update AAR's. The matrix-sdk.aar in this commit was built from the
v0.9.14 tag of the matrix-android-sdk git repository. olm-sdk.jar is
pulled from the same place.
Updates to the build scripts. matrix-android-sdk added kotlin as a
dependency, moved to okhttp3, added io.realm, and so on.
Code modifications to support new SDK itself. The changes, here, are
a grab bag, and you're best off just reading the commit.
Of particular note, here, is that LoginRestClient.loginWithUser takes a
device name and a device ID, now (the previous API only took a device
name). As a wicked hack, right now, I'm just using the name as the ID,
but I have no doubt that's wrong and this should be cleaned up to
include a randomly generated, persisted device ID, as I believe this is
used by Synapse to track login sessions.