Skip to content

scheduler: fix json tag for hot region scheduler config #3942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2021
Merged

scheduler: fix json tag for hot region scheduler config #3942

merged 2 commits into from
Aug 2, 2021

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Aug 2, 2021 •
edited
Loading

Signed-off-by: yisaer disxiaofei@163.com

What problem does this PR solve?

fix json tag for hot region scheduler config which will cause pd-ctl setting failed.

image

Release note

None

@Yisaer
address the comment
6e1ca11 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 2, 2021
@ti-chi-bot ti-chi-bot requested a review from disksing August 2, 2021 11:00
@Yisaer
address the comment
9bd1812 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2021
rleungx
rleungx reviewed Aug 2, 2021
View reviewed changes
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, it's better to add a unit test.

@codecov
Copy link

codecov bot commented Aug 2, 2021 •
edited
Loading

Codecov Report

Merging #3942 (9bd1812) into master (141ab52) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3942      +/-   ##
==========================================
- Coverage   74.66%   74.58%   -0.09%     
==========================================
  Files         246      246              
  Lines       25068    25068              
==========================================
- Hits        18717    18696      -21     
- Misses       4693     4706      +13     
- Partials     1658     1666       +8
Flag Coverage Δ
unittests 74.58% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region_config.go 80.95% <ø> (ø)
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/tso/tso.go 64.08% <0.00%> (-4.42%) ⬇️
server/schedule/region_scatterer.go 80.70% <0.00%> (-4.39%) ⬇️
server/statistics/hot_cache_task.go 75.00% <0.00%> (-4.17%) ⬇️
pkg/dashboard/adapter/manager.go 79.78% <0.00%> (-3.20%) ⬇️
server/member/member.go 65.24% <0.00%> (-1.61%) ⬇️
server/server.go 70.51% <0.00%> (-1.07%) ⬇️
server/schedule/operator_controller.go 84.75% <0.00%> (-0.80%) ⬇️
server/cluster/coordinator.go 73.42% <0.00%> (-0.70%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 141ab52...9bd1812. Read the comment docs.

@Yisaer
Copy link
Contributor Author

Yisaer commented Aug 2, 2021

/merge

@ti-chi-bot
Copy link
Member

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9bd1812

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 2, 2021
@ti-chi-bot ti-chi-bot merged commit 1b24b4a into tikv:master Aug 2, 2021
@lhy1024 lhy1024 mentioned this pull request Aug 5, 2021
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yisaer @ti-chi-bot @lhy1024 @rleungx