Skip to content

scheduler: reduce GetStore in hot-region-scheduler (#3870) #3911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 13, 2021
Merged

scheduler: reduce GetStore in hot-region-scheduler (#3870) #3911

merged 4 commits into from
Sep 13, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3870

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

What is changed and how it works?

Reduce GetStore in hot-region-scheduler. In addition to preventing panic caused by data inconsistency, it can also reduce the use of BasicCluster locks.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

Fix the bug that PD may panic during scaling out TiKV.

HunDunDM added 2 commits July 27, 2021 06:32
@HunDunDM @ti-chi-bot
scheduler: reduce GetStore in hot-region-scheduler
b8dc5b1 
Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM @ti-chi-bot
tiny fix
eef7208 
Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 27, 2021
Merged
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. component/scheduler Scheduler logic. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 The PR belongs to release-5.1 cherry pick. labels Jul 27, 2021
@ti-chi-bot ti-chi-bot requested review from disksing and lhy1024 July 27, 2021 06:32
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #3911 (eef7208) into release-5.1 (7cba191) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.1    #3911      +/-   ##
===============================================
- Coverage        75.10%   75.07%   -0.03%     
===============================================
  Files              245      245              
  Lines            24555    24563       +8     
===============================================
  Hits             18441    18441              
+ Misses            4504     4503       -1     
- Partials          1610     1619       +9
Flag Coverage Δ
unittests 75.07% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/utils.go 93.75% <ø> (ø)
server/schedulers/hot_region.go 84.82% <100.00%> (+0.89%) ⬆️
server/schedulers/shuffle_hot_region.go 65.30% <100.00%> (+10.56%) ⬆️
server/id/id.go 76.19% <0.00%> (-9.53%) ⬇️
server/region_syncer/server.go 83.33% <0.00%> (-6.07%) ⬇️
server/member/member.go 66.66% <0.00%> (-4.31%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/schedule/checker/rule_checker.go 80.11% <0.00%> (-1.11%) ⬇️
server/tso/allocator_manager.go 77.12% <0.00%> (-1.01%) ⬇️
server/core/storage.go 68.44% <0.00%> (-0.77%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cba191...eef7208. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2021
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 27, 2021
@HunDunDM HunDunDM modified the milestones: v5.1.1, v5.1.2 Jul 28, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 13, 2021
@nolouch
Copy link
Contributor

nolouch commented Sep 13, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: eef7208

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 13, 2021
@ti-chi-bot ti-chi-bot merged commit ca80632 into tikv:release-5.1 Sep 13, 2021
@bufferflies bufferflies mentioned this pull request Sep 22, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees

@HunDunDM HunDunDM

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/scheduler Scheduler logic. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 The PR belongs to release-5.1 cherry pick.
Projects
None yet
Milestone
v5.1.2
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @nolouch @disksing @lhy1024 @HunDunDM @zhouqiang-cl