server/balancer: check started operator #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the index is 0, the first operator may has started by not finished, so we need to add a flag to check whether the balancer has started.
siddontang
reviewed
Nov 3, 2016
| @@ -121,6 +122,11 @@ func (bo *balanceOperator) Do(ctx *opContext, region *regionInfo) (bool, *pdpb.R | |||
| return true, nil, nil | |||
| } | |||
|
|
|||
| if !bo.Started { | |||
| bo.Started = true | |||
| bo.Start = time.Now() | |||
There was a problem hiding this comment.
can we use Start only, if Start > 0, we can think the operator is started. And we will set Start to 0 after we finish the operator.
There was a problem hiding this comment.
Yep, and we don't need Finished too, I will remove it.
|
LGTM |
1 similar comment
|
LGTM |
|
CI failed @huachaohuang |
zhangjinpeng87
approved these changes
Nov 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the index is 0, the first operator may has started by not finished,
so we need to add a flag to check whether the balancer has started.
Closes #343.