Skip to content

scheduler: fix isHot in checkHot #3722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 31, 2021
Merged

scheduler: fix isHot in checkHot #3722

merged 8 commits into from
May 31, 2021

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented May 28, 2021 •
edited
Loading

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

fix isHot in checkHot

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

None

@lhy1024
fix isHot
de897e0 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 28, 2021
@ti-chi-bot ti-chi-bot requested review from nolouch and Yisaer May 28, 2021 07:58
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 28, 2021
@codecov
Copy link

codecov bot commented May 28, 2021 •
edited
Loading

Codecov Report

Merging #3722 (ce5b689) into master (35817bd) will increase coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3722      +/-   ##
==========================================
+ Coverage   75.01%   75.05%   +0.03%     
==========================================
  Files         244      244              
  Lines       24474    24480       +6     
==========================================
+ Hits        18360    18374      +14     
+ Misses       4492     4489       -3     
+ Partials     1622     1617       -5
Flag Coverage Δ
unittests 75.05% <85.71%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 81.33% <85.71%> (+0.01%) ⬆️
server/region_syncer/server.go 83.33% <0.00%> (-6.07%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
client/base_client.go 82.47% <0.00%> (-2.07%) ⬇️
pkg/btree/btree.go 85.30% <0.00%> (-0.97%) ⬇️
server/cluster/coordinator.go 72.19% <0.00%> (-0.71%) ⬇️
server/server.go 72.23% <0.00%> (-0.16%) ⬇️
server/tso/allocator_manager.go 79.13% <0.00%> (ø)
server/schedule/operator/step.go 68.43% <0.00%> (ø)
server/tso/tso.go 73.03% <0.00%> (+0.56%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35817bd...ce5b689. Read the comment docs.

lhy1024 added 2 commits May 28, 2021 17:15
@lhy1024
update
3267d6b 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
update
565d828 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 requested review from HunDunDM, rleungx and disksing May 28, 2021 09:27
HunDunDM
HunDunDM reviewed May 28, 2021
View reviewed changes
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 28, 2021
nolouch
nolouch reviewed May 28, 2021
View reviewed changes
server/schedulers/hot_region.go
@@ -817,7 +817,7 @@ func (bs *balanceSolver) calcProgressiveRank() {
dstRate := dstLd.Loads[dim]
peerRate := peer.GetLoad(getRegionStatKind(bs.rwTy, dim))
decRatio := (dstRate + peerRate) / getSrcDecRate(srcRate, peerRate)
isHot := peerRate >= bs.sche.conf.GetMinHotKeyRate()
isHot := peerRate >= bs.getMinRate(dim)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lhy1024
address comment
5830fe6 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 31, 2021
@lhy1024
Copy link
Contributor Author

lhy1024 commented May 31, 2021

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5830fe6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2021
rleungx
rleungx reviewed May 31, 2021
View reviewed changes
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2021
@lhy1024
Copy link
Contributor Author

lhy1024 commented May 31, 2021

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 85dba21

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2021
@ti-chi-bot ti-chi-bot merged commit b414f35 into tikv:master May 31, 2021
@lhy1024 lhy1024 deleted the fix-check-hot branch May 31, 2021 10:27
@nolouch nolouch mentioned this pull request Jul 13, 2021
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx left review comments

@nolouch nolouch nolouch approved these changes

@disksing disksing disksing approved these changes

@HunDunDM HunDunDM HunDunDM approved these changes

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lhy1024 @ti-chi-bot @nolouch @disksing @HunDunDM @rleungx