Cache all regions #125
Merged
Cache all regions #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iddontang/cache-regions
| } | ||
|
|
||
| func cloneRegion(r *metapb.Region) *metapb.Region { | ||
| if r == nil { |
There was a problem hiding this comment.
proto.Clone() checks if it is nil inside.
There was a problem hiding this comment.
Seems region should always be not nil? Do we really need to check this?
|
|
||
| if startKey == searchStartKey && endKey == searchEndKey { | ||
| // we are the same, must check epoch here. | ||
| if err := checkStaleRegion(searchRegion, region); err != nil { |
There was a problem hiding this comment.
should we check if searchRegion.version == region.version instead?
There was a problem hiding this comment.
no need now, because now the mechanism can guarantee that if range is same, the version is same.
But we may handle this later if we introduce merge. @qiuyesuifeng has added a comment here in another PR.
| } | ||
|
|
||
| return nil, nil | ||
| return c.cachedCluster.regions.GetRegion(regionKey), nil |
There was a problem hiding this comment.
GetRegion locks inner.
Add more cluster cache test.
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@qiuyesuifeng @disksing