[DNM]add user kv api #989
Closed
[DNM]add user kv api #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Connor1996
reviewed
Mar 13, 2018
| @@ -53,6 +53,12 @@ type Client interface { | |||
| // The store may expire later. Caller is responsible for caching and taking care | |||
| // of store change. | |||
| GetStore(ctx context.Context, storeID uint64) (*metapb.Store, error) | |||
| // GetUserKV get the user kv from pd. | |||
| @@ -53,6 +53,12 @@ type Client interface { | |||
| // The store may expire later. Caller is responsible for caching and taking care | |||
| // of store change. | |||
| GetStore(ctx context.Context, storeID uint64) (*metapb.Store, error) | |||
| // GetUserKV get the user kv from pd. | |||
| GetUserKV(ctx context.Context, key string) (string, error) | |||
| // PutUserKV put the user kv to pd. | |||
| GetUserKV(ctx context.Context, key string) (string, error) | ||
| // PutUserKV put the user kv to pd. | ||
| PutUserKV(ctx context.Context, key string, value string) error | ||
| // DeleteUserKV delete the user kv from pd. |
| @@ -555,3 +555,56 @@ func (s *Server) notBootstrappedHeader() *pdpb.ResponseHeader { | |||
| Message: "cluster is not bootstrapped", | |||
| }) | |||
| } | |||
|
|
|||
| // GetUserKV get key from pd under dir 'user'. | |||
| }, nil | ||
| } | ||
|
|
||
| // PutUserKV put key to pd under dir 'user'. |
| }, nil | ||
| } | ||
|
|
||
| // DeleteUserKV delete key from pd under dir 'user'. |
|
Is it necessary to use pd store the safepoint? @wentaoxu |
|
@zhangjinpeng1987 yes, I think it is the best now, sometimes we need to trace this value to debug some problems on gc. |
|
Close it for no activity for a long time. Please reopen it if need. |
ti-chi-bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /tools/pd-tso-bench (#5990) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref prometheus/client_golang#987, ref #987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ti-chi-bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /tests/client (#5992) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ti-chi-bot
added a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /tests/mcs (#5993) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /client (#5991) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title says, this used for gc
PTAL @zhangjinpeng1987 @disksing @nolouch