Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9173

What problem does this PR solve?

Issue Number: Close #9156.

What is changed and how does it work?

According to the maintainer's comment in etcd-io/etcd#18091 (reply in thread). It is not recommended to use a short lease, which is less than 3s. I think we also need to change the default lease.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels May 9, 2025
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.59%. Comparing base (71d81bd) to head (3ba5f78).
Report is 1 commits behind head on release-8.5.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-8.5    #9305   +/-   ##
============================================
  Coverage        75.59%   75.59%           
============================================
  Files              462      462           
  Lines            72430    72430           
============================================
+ Hits             54753    54757    +4     
+ Misses           14170    14169    -1     
+ Partials          3507     3504    -3     
Flag Coverage Δ
unittests 75.59% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 9, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 12, 2025
Copy link
Contributor

ti-chi-bot bot commented May 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-09 11:02:10.17439765 +0000 UTC m=+97396.322358863: ☑️ agreed by JmPotato.
  • 2025-05-12 02:55:13.387288395 +0000 UTC m=+327379.535249613: ☑️ agreed by lhy1024.

Copy link
Contributor

ti-chi-bot bot commented May 12, 2025

@rleungx: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so.

In response to adding label named approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot removed the approved label May 12, 2025
Copy link
Contributor

ti-chi-bot bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024, niubell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 12, 2025
@ti-chi-bot ti-chi-bot bot merged commit bac6558 into tikv:release-8.5 May 12, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants