-
Notifications
You must be signed in to change notification settings - Fork 742
config: increase the default lease (#9173) #9305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: increase the default lease (#9173) #9305
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #9305 +/- ##
============================================
Coverage 75.59% 75.59%
============================================
Files 462 462
Lines 72430 72430
============================================
+ Hits 54753 54757 +4
+ Misses 14170 14169 -1
+ Partials 3507 3504 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
@rleungx: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so. In response to adding label named approved. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, lhy1024, niubell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #9173
What problem does this PR solve?
Issue Number: Close #9156.
What is changed and how does it work?
According to the maintainer's comment in etcd-io/etcd#18091 (reply in thread). It is not recommended to use a short lease, which is less than 3s. I think we also need to change the default lease.
Check List
Tests
Release note