Skip to content

test: add follower proxy when pd leader changed #9243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

test: add follower proxy when pd leader changed #9243

wants to merge 4 commits into from

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Apr 23, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #9188

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

Release note

None.

@bufferflies
add uinit test
e3d32fa 
Signed-off-by: 童剑 <1045931706@qq.com>
@bufferflies
add test for tso
42e6dd3 
Signed-off-by: 童剑 <1045931706@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Apr 23, 2025
@bufferflies bufferflies mentioned this pull request Apr 23, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.11%. Comparing base (ca6e36a) to head (42e6dd3).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9243      +/-   ##
==========================================
+ Coverage   76.01%   76.11%   +0.09%     
==========================================
  Files         470      470              
  Lines       73103    73028      -75     
==========================================
+ Hits        55568    55583      +15     
+ Misses      14082    14017      -65     
+ Partials     3453     3428      -25
Flag Coverage Δ
unittests 76.11% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rleungx rleungx changed the title Test: add follower proxy when pd leader changed test: add follower proxy when pd leader changed Apr 24, 2025
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Apr 25, 2025
Tema
Tema reviewed Apr 25, 2025
View reviewed changes
tests/integrations/tso/client_test.go
_, _, err = pdClient.GetTS(reqCtx)
re.ErrorContains(err, "requested pd is not leader of cluster")
pdCluster.WaitLeader()
// it will work when pull/9219 is merged
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can delete this line

Tema
Tema approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@Tema Tema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test!

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2025

@Tema: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Thanks for the test!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Tema
Once this PR has been reviewed and has the lgtm label, please ask for approval from bufferflies, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Tema
Copy link
Contributor

Tema commented May 23, 2025

@bufferflies can you land it or want me to take over?

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Tema Tema Tema approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bufferflies @Tema