Skip to content

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Mar 3, 2025

What problem does this PR solve?

Issue Number: Ref #8582

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: okJiang <819421878@qq.com>
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.32%. Comparing base (a42aa2b) to head (9803e41).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9112      +/-   ##
==========================================
+ Coverage   76.28%   76.32%   +0.04%     
==========================================
  Files         473      473              
  Lines       71663    71663              
==========================================
+ Hits        54665    54700      +35     
+ Misses      13572    13547      -25     
+ Partials     3426     3416      -10     
Flag Coverage Δ
unittests 76.32% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@ -55,6 +57,7 @@ func (s *clusterSuite) SetupSuite() {

s.cluster = newCluster(re, s.tag(), dataDir, s.mode)
s.cluster.start()
s.cli = newPDClient(re)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close it in TearDownSuite

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 4, 2025
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2025
@okJiang
Copy link
Member Author

okJiang commented Mar 5, 2025

/retest

Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to pick it to other branches?

Copy link
Contributor

ti-chi-bot bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 5, 2025
Copy link
Contributor

ti-chi-bot bot commented Mar 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-04 08:36:47.837202453 +0000 UTC m=+344320.966122190: ☑️ agreed by rleungx.
  • 2025-03-05 02:34:24.53616194 +0000 UTC m=+408977.665081683: ☑️ agreed by lhy1024.

@okJiang
Copy link
Member Author

okJiang commented Mar 5, 2025

LGTM. Do we need to pick it to other branches?

No need

@ti-chi-bot ti-chi-bot bot merged commit 5d8faba into tikv:master Mar 5, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants