-
Notifications
You must be signed in to change notification settings - Fork 742
test/realcluster: add safe_point case to etcd key #9112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: okJiang <819421878@qq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9112 +/- ##
==========================================
+ Coverage 76.28% 76.32% +0.04%
==========================================
Files 473 473
Lines 71663 71663
==========================================
+ Hits 54665 54700 +35
+ Misses 13572 13547 -25
+ Partials 3426 3416 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -55,6 +57,7 @@ func (s *clusterSuite) SetupSuite() { | |||
|
|||
s.cluster = newCluster(re, s.tag(), dataDir, s.mode) | |||
s.cluster.start() | |||
s.cli = newPDClient(re) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
close it in TearDownSuite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM.
Signed-off-by: okJiang <819421878@qq.com>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do we need to pick it to other branches?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No need |
What problem does this PR solve?
Issue Number: Ref #8582
What is changed and how does it work?
Check List
Tests
Release note