tests: make TestRemovingProgress stable
#9103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9103 +/- ##
==========================================
- Coverage 76.29% 76.26% -0.04%
==========================================
Files 473 473
Lines 71663 71663
==========================================
- Hits 54677 54654 -23
- Misses 13559 13577 +18
- Partials 3427 3432 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
c61200f to
383f8dd
Compare
Signed-off-by: Ryan Leung <rleungx@gmail.com>
383f8dd to
a607758
Compare
|
/unhold |
bufferflies
approved these changes
Feb 27, 2025
JmPotato
approved these changes
Feb 27, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, JmPotato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #8992.
What is changed and how does it work?
The test failed because we enabled
highFrequencyClusterJobsfailpoint to makecheckStoresexecute ASAP. However, it could cause runningcheckStoresmultiple times if the environment is in a high load state. In this case, the data point in the progress window will increase which results in speed inaccuracy.Check List
Tests
Release note