Skip to content

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 24, 2025

What problem does this PR solve?

Issue Number: Close #9098

What is changed and how does it work?

The internal update member loop may be executed at the same time to change the value.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.35%. Comparing base (6504311) to head (e8de3f3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9099   +/-   ##
=======================================
  Coverage   76.34%   76.35%           
=======================================
  Files         468      468           
  Lines       71729    71729           
=======================================
+ Hits        54765    54771    +6     
+ Misses      13550    13544    -6     
  Partials     3414     3414           
Flag Coverage Δ
unittests 76.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx requested review from JmPotato and lhy1024 February 24, 2025 09:49
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 25, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bufferflies,lhy1024]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 25, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 25, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-25 06:18:29.467519409 +0000 UTC m=+336657.420677678: ☑️ agreed by lhy1024.
  • 2025-02-25 07:01:55.509090152 +0000 UTC m=+339263.462248418: ☑️ agreed by bufferflies.

@rleungx
Copy link
Member Author

rleungx commented Feb 25, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 8a0b897 into tikv:master Feb 25, 2025
25 checks passed
@rleungx rleungx deleted the fix-race14 branch February 25, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data race in TestMemberUpdateBackOff
3 participants