Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8757

What problem does this PR solve?

Issue Number: Close #8756

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

)

close tikv#8756

Signed-off-by: okJiang <819421878@qq.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jan 6, 2025
Signed-off-by: okJiang <819421878@qq.com>
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.59%. Comparing base (98df926) to head (995075d).
Report is 2 commits behind head on release-8.5.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-8.5    #8973      +/-   ##
===============================================
+ Coverage        75.53%   75.59%   +0.06%     
===============================================
  Files              462      462              
  Lines            72355    72364       +9     
===============================================
+ Hits             54650    54704      +54     
+ Misses           14194    14155      -39     
+ Partials          3511     3505       -6     
Flag Coverage Δ
unittests 75.59% <28.57%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 6, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 6, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-06 06:31:42.456834465 +0000 UTC m=+162445.745666168: ☑️ agreed by okJiang.
  • 2025-01-06 06:38:53.4415167 +0000 UTC m=+162876.730348408: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit fed784a into tikv:release-8.5 Jan 6, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants