grafana: Add gRPC Received commands rate panel
#8921
Conversation
Signed-off-by: okJiang <819421878@qq.com>
gRPC Received commands rategRPC Received commands rate panel
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8921 +/- ##
==========================================
+ Coverage 76.22% 76.29% +0.06%
==========================================
Files 464 464
Lines 70516 70516
==========================================
+ Hits 53754 53802 +48
+ Misses 13407 13375 -32
+ Partials 3355 3339 -16
Flags with carried forward coverage won't be shown. Click here to find out more. |
metrics/grafana/pd.json
Outdated
| "spaceLength": 10, | ||
| "targets": [ | ||
| { | ||
| "expr": "sum(rate(grpc_server_started_total{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", instance=~\"$instance\"}[1m])) by (instance, grpc_method)", |
There was a problem hiding this comment.
How about also adding the error rate?
There was a problem hiding this comment.
I added it. But btw, it can't catch the error hide in the header, like this
Line 2071 in 2d970a6
There was a problem hiding this comment.
Please add a comment or raise an issue for further improvement.
Signed-off-by: okJiang <819421878@qq.com>
Signed-off-by: okJiang <819421878@qq.com>
|
/retest |
Signed-off-by: okJiang <819421878@qq.com>
…g/pd into add-grpc-received-metrics
|
/retest |
|
ping @rleungx @bufferflies |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
What problem does this PR solve?
Issue Number: Close #8920
What is changed and how does it work?
Check List
Tests
Release note