Skip to content

chore(dashboard): update TiDB Dashboard to v8.5.0-bce95733 (#8764) #8772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 27, 2024
Merged

chore(dashboard): update TiDB Dashboard to v8.5.0-bce95733 (#8764) #8772

merged 2 commits into from
Dec 27, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8764

What problem does this PR solve?

Issue Number: ref #4257 #8767

Update TiDB Dashboard to v8.5.0-bce95733.

Release note

None

@baurine @ti-chi-bot
chore(dashboard): update TiDB Dashboard to v8.5.0-bce95733
beb543a 
Signed-off-by: baurine <2008.hbl@gmail.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 5, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 5, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.57%. Comparing base (d190c0e) to head (a3ab827).
⚠️ Report is 29 commits behind head on release-8.5.

❌ Your project status has failed because the head coverage (50.00%) is below the target coverage (74.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-8.5    #8772      +/-   ##
===============================================
- Coverage        75.67%   75.57%   -0.10%     
===============================================
  Files              462      462              
  Lines            72355    72355              
===============================================
- Hits             54755    54683      -72     
- Misses           14111    14177      +66     
- Partials          3489     3495       +6
Flag Coverage Δ
unittests 50.00% <ø> (-9.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 11, 2024
@rleungx rleungx changed the title chore(dashboard): update TiDB Dashboard to v8.5.0-bce95733 [master] (#8764) chore(dashboard): update TiDB Dashboard to v8.5.0-bce95733 (#8764) Dec 11, 2024
@rleungx
Copy link
Member

rleungx commented Dec 18, 2024

Fixed by #8764

@rleungx rleungx closed this Dec 18, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 19, 2024
@rleungx rleungx reopened this Dec 24, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 25, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 25, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-11 07:27:30.659979584 +0000 UTC m=+423440.748782127: ☑️ agreed by rleungx.
  • 2024-12-25 08:39:46.281240933 +0000 UTC m=+1637376.370043475: ☑️ agreed by JmPotato.

@baurine
Copy link
Contributor

baurine commented Dec 26, 2024

/test

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 26, 2024

@baurine: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test build

The following commands are available to trigger optional jobs:

/test pull-integration-copr-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/ghpr_build

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jebter
Copy link
Collaborator

jebter commented Dec 27, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 98df926 into tikv:release-8.5 Dec 27, 2024
22 checks passed
@ti-chi-bot ti-chi-bot bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Aug 5, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 5, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/cherry-pick-not-approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @rleungx @baurine @jebter @JmPotato