Skip to content

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Oct 22, 2024

What problem does this PR solve?

Issue Number: Close #8736

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 22, 2024
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2024
@okJiang
Copy link
Member Author

okJiang commented Oct 22, 2024

/retest

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.53%. Comparing base (0402e15) to head (0c1cdd3).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8734      +/-   ##
==========================================
+ Coverage   70.10%   75.53%   +5.42%     
==========================================
  Files         517      460      -57     
  Lines       79983    72101    -7882     
==========================================
- Hits        56076    54464    -1612     
+ Misses      20339    14154    -6185     
+ Partials     3568     3483      -85     
Flag Coverage Δ
unittests 75.53% <ø> (+5.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@okJiang okJiang changed the title [WIP] ci: ignore codecov path ci: ignore codecov path Oct 22, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 22, 2024
codecov.yml Outdated
@@ -24,3 +24,8 @@ flag_management:
target: 74% # increase it if you want to enforce higher coverage for project, current setting as 74% is for do not let the error be reported and lose the meaning of warning.
- type: patch
target: 74% # increase it if you want to enforce higher coverage for project, current setting as 74% is for do not let the error be reported and lose the meaning of warning.

ignore:
- "tools"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep the pd control.

Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2024
@okJiang
Copy link
Member Author

okJiang commented Oct 23, 2024

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-22 08:45:51.612659881 +0000 UTC m=+340752.309450514: ☑️ agreed by lhy1024.
  • 2024-10-23 09:15:18.24669155 +0000 UTC m=+428918.943482160: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 24343e4 into tikv:master Oct 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

current codecov doesn't reach our goal 74%
3 participants