Skip to content

metrics: modify hot grafana panel #6802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 14, 2023
Merged

metrics: modify hot grafana panel #6802

merged 4 commits into from
Jul 14, 2023

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Jul 13, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #4350

What is changed and how does it work?

1. devide Hot `Select event` into `Select read event` and `Select write event`
2. add new panel to show the `hot write bytes of the leader region`

Check List

Tests

  • Manual test (add detailed scripts or steps below)
image image

Code changes

Side effects

Related changes

Release note

None.

@bufferflies
hot metrics
d0fdc88 
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 13, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jul 13, 2023
@ti-chi-bot ti-chi-bot bot requested review from rleungx and Yisaer July 13, 2023 08:22
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 13, 2023
@bufferflies
Copy link
Contributor Author

/run-monitor-test

@ti-chi-bot ti-chi-bot bot added status/LGT1 Indicates that a PR has LGTM 1. and removed do-not-merge/needs-linked-issue labels Jul 13, 2023
HuSharp
HuSharp reviewed Jul 13, 2023
View reviewed changes
@bufferflies
add description
bd42962 
Signed-off-by: bufferflies <1045931706@qq.com>
@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #6802 (fa1c61b) into master (42ce6a1) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6802      +/-   ##
==========================================
+ Coverage   74.10%   74.25%   +0.14%     
==========================================
  Files         413      413              
  Lines       43410    43410              
==========================================
+ Hits        32168    32233      +65     
+ Misses       8362     8307      -55     
+ Partials     2880     2870      -10
Flag Coverage Δ
unittests 74.25% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 13, 2023
@bufferflies
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2023

This pull request has been accepted and is ready to merge.

Commit hash: bd42962

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2023
@ti-chi-bot ti-chi-bot bot merged commit 5728238 into tikv:master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@HuSharp HuSharp HuSharp approved these changes

@rleungx rleungx Awaiting requested review from rleungx

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hot region grafana should be more clearier
3 participants
@bufferflies @lhy1024 @HuSharp